Fix infoset realisation probability for absent-minded information sets#835
Open
d-kad wants to merge 4 commits intogambitproject:masterfrom
Open
Fix infoset realisation probability for absent-minded information sets#835d-kad wants to merge 4 commits intogambitproject:masterfrom
d-kad wants to merge 4 commits intogambitproject:masterfrom
Conversation
…tries and IsAbsentMindedReentry
…cached m_infosetProbs in ComputeRealizationProbs
… an absent-minded information set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes information set realisation probability for games with absent-mindedness. The previous implementation summed node realisation probabilities across all members, double-counting it for the nodes along the same path, with probabilities summing above 1 in this case.
The corrected infoset realisation probability is the probability the information set is visited at least once. The implementation identifies reentry nodes (members whose path from the root passes through the same information set) and excludes them from the sum.
C++ changes:
m_absentMindedReentriescache inGameTreeRep, populated insideBuildUnreachableNodes(it already correctly treats the absent-minded reentry)IsAbsentMindedReentry()m_infosetProbscache, populated insideComputeRealizationProbsTest changes:
test_absent_minded_infoset_probcoveringnoPR-AM-driver-one-player.efgandnoPR-action-AM.efgwith uniform probability distributions over actionsCloses #826